Include hardware info in diagnostic snapshot & restructure properties#270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the logic that prepares a diagnostic snapshot and also includes hardware info. The snapshot is only written to Petrichor's log file without leaving the user's device; the app doesn't read any privacy-violating information to prepare the snapshot and is only intended to provide detailed info on the current setup while reporting a problem.
Here's what a sample snapshot looks like (as shown from my own Petrichor installation);
{ "app" : { "build" : "debug", "bundleId" : "org.Petrichor.debug", "name" : "Petrichor", "version" : "1.5.1" }, "device" : { "arch" : "arm64", "logicalCores" : 10, "memory" : "32 GB", "model" : "MacBookPro18,2", "os" : "Version 26.4.1 (Build 25E253)", "physicalCores" : 10, "processor" : "Apple M1 Max", "storageAvailable" : "589.64 GB", "storageTotal" : "994.66 GB" }, "equalizer" : { "eqEnabled" : true, "eqPreset" : "wow", "preampGain" : null, "stereoWideningEnabled" : false }, "library" : { "albumCount" : 550, "artistCount" : 549, "folderCount" : 6, "folders" : [ "\/Users\/kushal\/Library\/CloudStorage\/OneDrive-Personal\/Music\/Albums", "\/Users\/kushal\/Library\/CloudStorage\/OneDrive-Personal\/Music\/Collection", "\/Users\/kushal\/Library\/CloudStorage\/OneDrive-Personal\/Music\/Extras\/Hans Zimmer", "\/Users\/kushal\/Library\/CloudStorage\/OneDrive-Personal\/Music\/Extras\/John Mayer", "\/Users\/kushal\/Library\/CloudStorage\/OneDrive-Personal\/Music\/Extras\/Kites", "\/Users\/kushal\/Library\/CloudStorage\/OneDrive-Personal\/Music\/Yanni" ], "formats" : { "m4a" : 1556, "mp3" : 279 }, "lastScanDate" : null, "pinnedItemCount" : 6, "playlistCount" : 5, "totalDurationSec" : 538379, "totalSize" : "19.42 GB", "trackCount" : 1835 }, "others" : { "albumSortBy" : "album", "entitySortAscending" : true, "librarySelectedFilterType" : "Albums", "playlistSortAscending" : false, "playlistSortFields" : null, "trackColumns" : [ "title", "album", "dateAdded", "duration", "artist", "trackNumber", "favorite", "year" ], "trackTableRowSize" : "expanded" }, "phase" : "Termination", "settings" : { "general" : { "automaticUpdatesEnabled" : true, "closeToMenubar" : true, "colorMode" : "Auto", "hideDuplicateTracks" : true, "showFoldersTab" : false, "startAtLogin" : false, "useArtworkColors" : true }, "library" : { "autoScanInterval" : "onlyOnLaunch", "discoverTrackCount" : 50, "discoverUpdateInterval" : "weekly" }, "online" : { "artistInfoFetchEnabled" : true, "lastfmUsername" : "<set>", "loveSyncEnabled" : false, "onlineLyricsEnabled" : true, "scrobblingEnabled" : false } }, "uniqueId" : "<Unique ID string generated from Bundle ID of installation>" }